-
Notifications
You must be signed in to change notification settings - Fork 517
58 Unit test fixes for matter test cases #2311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
58 Unit test fixes for matter test cases #2311
Conversation
This change covers the matter test case updates associated with #2310.
|
Channel deleted. |
Test Results 68 files ± 0 448 suites +1 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit f39f3f7. ± Comparison against base commit 0fcd44c. This pull request removes 286 and adds 14 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
matter-appliance_coverage.xml
matter-button_coverage.xml
matter-energy_coverage.xml
matter-lock_coverage.xml
matter-media_coverage.xml
matter-rvc_coverage.xml
matter-sensor_coverage.xml
matter-switch_coverage.xml
matter-thermostat_coverage.xml
matter-window-covering_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 067efc5 |
This commit also includes a small fix for LuaLibs v15+.
|
Tests are looking good. 👍 Looks like there are 3 failing tests still due to modular profile changes which I think fall outside the scope of these changes (and would be fixed by a different PR). |
Ah yeah, good catch - those will be fixed by #2326! |
aleclorimer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cjswedes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely an improvement. All my comments are not blocking for merge and are only really about making everything consistent for when we use disable_startup_messages and when we dont. If we are simulating a device join where we expect added/doConfigure, then we should disable the startup messages, but if we are avoiding added, and only need init/doConfigure, the preferred approach would be to let the test framework queue those events (doConfigure only queued if the device is not provisioned).
drivers/SmartThings/matter-lock/src/test/test_new_matter_lock_battery.lua
Show resolved
Hide resolved
drivers/SmartThings/matter-media/src/test/test_matter_media_video_player.lua
Outdated
Show resolved
Hide resolved
drivers/SmartThings/matter-sensor/src/test/test_matter_freeze_leak_sensor.lua
Show resolved
Hide resolved
|
I'm going to leave these commits unsquashed within this PR but use Squash and Merge to merge into the main PR. |
6bb6f9f
into
test/58-unit-test-fixes
|
Invitation URL: |
This commit covers the matter test case updates associated with #2310.
This commit covers the matter test case updates associated with #2310.
This PR covers the matter test case updates associated with #2310.